[Kde-games-devel] Re: Review Request: Show game names in combobox of the statistics dialog translated

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5702/#review8403
-----------------------------------------------------------



trunk/KDE/kdegames/kpat/statisticsdialog.cpp
<http://svn.reviewboard.kde.org/r/5702/#comment8725>

    Actually, I think the translation should be happening here. The purpose of temporarily storing the games in the nameToIdMap is to ensure that they're sorted alphabetically. So the right answer is to replace the QString constructor on this line with a i18n call.
    
    Really this illustrates how the handling of game names really needs so refactoring in KPat. These translations should be done once and cached. It would prevent mistakes like these.


- Parker


On 2010-10-27 20:08:40, Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5702/
> -----------------------------------------------------------
> 
> (Updated 2010-10-27 20:08:40)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Add missing i18n() call to make game names in combobox of the statistics dialog translated
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=252586.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=252586
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kpat/statisticsdialog.cpp 1189578 
> 
> Diff: http://svn.reviewboard.kde.org/r/5702/diff
> 
> 
> Testing
> -------
> 
> run kpat in locale x-test (KDE_LANG=x-test kpat), open statistics dialog with Game->Statistics.
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20101028/233b7979/attachment.html