[Kde-games-devel] Re: Review Request: [Klickety] Remove Quit from default toolbar layout

[shuizhuyuanluo at 126.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5768/#review8521
-----------------------------------------------------------

Ship it!


It is so strange that I haven't got the email notification of this review request  =_=!
ok, please commit this change.


- nihui


On 2010-11-04 20:25:12, Stefan Majewsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5768/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 20:25:12)
> 
> 
> Review request for KDE Games and nihui.
> 
> 
> Summary
> -------
> 
> This patch removes the "Quit" action from Klickety's toolbar. Including this action in the default toolbar layout is very uncommon because the window manager's X button, which serves the same purpose, is readily available at a standardized position. The initial motivation for me was that the default toolbar does not fit into the default window size.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/klickety/klicketyui.rc 1192715 
> 
> Diff: http://svn.reviewboard.kde.org/r/5768/diff
> 
> 
> Testing
> -------
> 
> Installed, works (though I've not bumped the ui.rc version, because Klickety in trunk is still young).
> 
> 
> Thanks,
> 
> Stefan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20101106/6821be6c/attachment.htm