[Kde-games-devel] Re: Review Request: Standardise formatting of command line options

[Parker Coates]

> On 2010-11-02 11:32:25, Frederik Schwarzer wrote:
> > I think consistency is nice even at places that are not seem much.
> > Is it possible to keep the old options but do not show them to the user?
> > If so, I would prefer doing that for a while as the non-breaking way.
> > If not, I still think it should not be such a big problem. So I
> > am fine with this change.

I had considered that, but as far as I can tell KCmdLineArgs/KCmdLineOptions reject any arguments that are not explicitly listed. Even if it did, I'm not convinced we'd want to clutter up the code by checking both alternatives.

Thanks.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5754/#review8473
-----------------------------------------------------------


On 2010-11-02 05:45:56, Parker Coates wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5754/
> -----------------------------------------------------------
> 
> (Updated 2010-11-02 05:45:56)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Tonight I noticed that Klickety was using --CamelCase for its command line options instead of KDE's "standard" --lower-case-hyphenated. When I asked Ni about it he said he just copied the formatting from KDiamond. This prompted me to take a look around the module and produce this patch. It corrects all the "non-standard" options I could find.
> 
> (Note that while lower-casing is near universal in KDE apps, hyphenation versus alloneword is not as clear cut. After an informal survey of some popular KDE applications it does seem that hyphenation is the more popular option.)
> 
> Since, Klickety is a new app, I believe its options should be fixed, but I'm not really sure about the rest. On the one hand, consistency is really nice to have. On the other, changing the options could theoretically break existing scripts and shortcuts. On the one hand, command line arguments (especially those included in this patch) are quite unlikely to be much used. On the other, if they're not heavily used, why would we care if they're consistent or not.
> 
> So I thought I'd throw up this patch as a point of conversation. What do people think.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/katomic/main.cpp 1192115 
>   trunk/KDE/kdegames/kdiamond/src/main.cpp 1192115 
>   trunk/KDE/kdegames/kfourinline/src/main.cpp 1192115 
>   trunk/KDE/kdegames/klickety/ksame.desktop 1192115 
>   trunk/KDE/kdegames/klickety/main.cpp 1192115 
>   trunk/KDE/kdegames/knetwalk/src/main.cpp 1192115 
>   trunk/KDE/kdegames/kpat/main.cpp 1192115 
>   trunk/KDE/kdegames/lskat/src/main.cpp 1192115 
> 
> Diff: http://svn.reviewboard.kde.org/r/5754/diff
> 
> 
> Testing
> -------
> 
> None. If we agree that this patch (or part of it) is worth doing I'll test that the renamed options work as expected.
> 
> 
> Thanks,
> 
> Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20101102/2b7cb483/attachment-0001.htm