[Kde-games-devel] Review Request: Hint in Kiriki

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3793/#review5582
-----------------------------------------------------------



/trunk/KDE/kdegames/kiriki/src/diceswidget.cpp
<http://reviewboard.kde.org/r/3793/#comment5270>

    There must be a prettier way of highlighting the dice. I'll see what I can come up with.



/trunk/KDE/kdegames/kiriki/src/diceswidget.cpp
<http://reviewboard.kde.org/r/3793/#comment5269>

    I'm guessing something was supposed to happen here. :)



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3793/#comment5274>

    Includes should generally be kept alphabetised. I realise that the original code wasn't entirely ordered to begin with, but it probably make sense to add this include just above kmessagebox.h.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3793/#comment5285>

    In many (most?) of our games hints behave one of two ways:
    
    1. The hint is shown only for a short while and then disappears.
    
    2. The hint is shown and remains shown, but is hidden if the hint action is triggered again.
    
    I'm not saying that either of this is strictly necessary for Kiriki, but it is something to consider.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3793/#comment5286>

    Do you think it would be possible to indicate the recommended row by highlighting it directly? I think that would simplify things considerably.
    
    If not, I think the text needs work. It's a tricky concept to describe in a short message, but the best I've come up with is 'Record as "something".'


- Parker


On 2010-05-01 04:04:26, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3793/
> -----------------------------------------------------------
> 
> (Updated 2010-05-01 04:04:26)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements hint in Kiriki, using the computer itself to give it. The tips are shown in the status bar - that is hidden right after the roll.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/scores.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1119312 
> 
> Diff: http://reviewboard.kde.org/r/3793/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>