[Kde-games-devel] Review Request: KMines: fix the problem, where the too early starting timer can result in revealing a mine on the first click

[Frederik Schwarzer]

> On 2009-07-15 07:56:26, Dmitry Suzdalev wrote:
> > Committed

Clemens, can you close this review, please?


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/158/#review1612
-----------------------------------------------------------


On 2009-05-13 13:01:14, Clemens Werther wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/158/
> -----------------------------------------------------------
> 
> (Updated 2009-05-13 13:01:14)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Change 1 and 5:
> This puts the "first-click-detection" routine where it belongs.
> 
> Change 2:
> press left; press mid; release left; move mouse over another cell; press left; release mid; release left
> 
> Without the change, the timer would start, although no item is revealed (only really visible after applying change 1 and 5, because without, the timer even starts when any mouse button is down... ).
>  
> Change 3 and 4:
> press left; press mid; release left; release mid
> 
> Without the change, this would result in a pressed item, although the mouse is not pressed anymore.
>  
> 
> After applying the whole patch, situations like the one in the screenshot shouldn't be possible anymore.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmines/minefielditem.cpp 925889 
> 
> Diff: http://reviewboard.kde.org/r/158/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> fail at first click
>   http://reviewboard.kde.org/r/158/s/29/
> 
> 
> Thanks,
> 
> Clemens
> 
>