[Kde-games-devel] Review Request: Added difficuly level into kbounce.

[Parker Coates]

> On 2010-03-19 15:59:58, Parker Coates wrote:
> > Just a couple things.
> > 
> > - I still object to you listing yourself as an author.
> > - You now have issues with removed trailing whitespace. Trailing whitespace is a pain and should probably be removed, but this is best done in a separate commit. For you, it'd probably be easiest to do the whitespace only commit first.
> 
> Andreas Scherf wrote:
>     Ok, which person is to contact for adding me as author?
>     I have enabled "remove trailing spaces while editing". But what did you mean? Should i remove all trailing whitespace and after that i should rewrite the whole patch? I would prefer to commit now and after that i remove all trailing whitespace.

The term "author" is generally reserved for people who have written (or rewritten) significant portions of the code base, which I don't think applies to you at the moment. So I would recommend moving the line below Dmitri's and changing it from

  aboutData.addAuthor(ki18n("Andreas Scherf"),ki18n("Some improvements and fixes"),"ascherfy at gmail.com");

to

  aboutData.addCredit(ki18n("Andreas Scherf"), ki18n("Difficulty switching"), "ascherfy at gmail.com");

If you look at your patch, you'll see that there are hundreds of lines where the only changes are to whitespace. Sometimes leading whitespace was removed, sometimes trailing whitespace was removed and sometimes tabs were replaced with spaces. In addition to making the diff unreadable, this makes a mess of VCS history. SVN will now "blame" you for hundreds of lines that you changed only accidentally. You'll need to go through and revert all such lines and make the lines you actually did change match the whitespace of the surrounding code, including using tabs.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3077/#review4573
-----------------------------------------------------------


On 2010-03-19 15:42:45, Andreas Scherf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3077/
> -----------------------------------------------------------
> 
> (Updated 2010-03-19 15:42:45)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Fullfilled the wishlist item 219507. I added 3 difficulty levels into kbounce (easy,medium,hard)
> Medium hat the default settings and (Easy,Hard) have different velocity settings for walls and balls.
> The problem is now is Difficulty:Hard playable anymore?
> 
> 
> This addresses bug 219507.
>     https://bugs.kde.org/show_bug.cgi?id=219507
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbounce/backgroundselector.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/board.h 1104903 
>   /trunk/KDE/kdegames/kbounce/board.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/gamewidget.h 1104903 
>   /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/main.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/mainwindow.h 1104903 
>   /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/wall.h 1104903 
>   /trunk/KDE/kdegames/kbounce/wall.cpp 1104903 
> 
> Diff: http://reviewboard.kde.org/r/3077/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas
> 
>