[Kde-games-devel] Review Request: Added difficuly level into kbounce.

[Parker Coates]

> On 2010-03-18 21:39:51, Parker Coates wrote:
> > /trunk/KDE/kdegames/kbounce/mainwindow.cpp, lines 258-264
> > <http://reviewboard.kde.org/r/3077/diff/1/?file=20252#file20252line258>
> >
> >     Why add empty switch cases?
> 
> Andreas Scherf wrote:
>     To show all different cases. At the moment this a hint only. 
>     I think a compiler would remove this lines. 
>     Should i comment them out or remove them completely?
> 
> Parker Coates wrote:
>     I guess this is more a matter of style than anything else. If I had unhandled enum values, I probably would have just included an empty default case. But I could see the argument for including all the values explicitly even if they don't do anything.
>     
>     Again an issue of style, but I probably would have dropped the first two break statements.
> 
> Andreas Scherf wrote:
>     I could remove those empty cases. But if i remove the breaks it changes the 
>     logic of this block. without breaks it is BeforeFirstGame == BetweenLevels==Suspended.
>     At the moment this states are not used, but i need them for some more improvements.
>     For example: Before thr first game i want to initialize the status bar with usefull values.
>     But thats future.

Yeah, that's fine. I was just inquisitive as to why you made such a change when it had nothing to do with the goal of this particular patch. Yet another reason to keep patches restricted to a single feature or bug fix. It keeps nosey reviewers from asking too many questions. :)


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3077/#review4557
-----------------------------------------------------------


On 2010-03-18 22:04:20, Andreas Scherf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3077/
> -----------------------------------------------------------
> 
> (Updated 2010-03-18 22:04:20)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Fullfilled the wishlist item 219507. I added 3 difficulty levels into kbounce (easy,medium,hard)
> Medium hat the default settings and (Easy,Hard) have different velocity settings for walls and balls.
> The problem is now is Difficulty:Hard playable anymore?
> 
> 
> This addresses bug 219507.
>     https://bugs.kde.org/show_bug.cgi?id=219507
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbounce/backgroundselector.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/board.h 1104903 
>   /trunk/KDE/kdegames/kbounce/board.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/gamewidget.h 1104903 
>   /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/main.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/mainwindow.h 1104903 
>   /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1104903 
>   /trunk/KDE/kdegames/kbounce/wall.h 1104903 
>   /trunk/KDE/kdegames/kbounce/wall.cpp 1104903 
> 
> Diff: http://reviewboard.kde.org/r/3077/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas
> 
>