[Kde-games-devel] kajongg in kdereview since 1 month

[Johannes Obermayr]

Am Samstag, 13. März 2010 17:51:54 schrieb Wolfgang Rohdewald:
> That is a long time. I believe there are no objections
> left, so -
> 
> Matt, would you agree to put kajongg into KDE SC 4.5, the 
> main kdegames module?
> 
> btw I am still adding features and will continue to do so
> but I think kajongg is in pretty good shape. The remaining things
> should be no obstacle like adding one last game rule which
> is needed only rarely, making the AI players more intelligent,
> adding more rulesets, adding voices (partially done today)
> 
> should anybody look at the python source - krazy does not -
> there are some QDialog instead of KDialog, but I cannot
> change that. KDialogButtonBox.addButton expects a C++ slot
> but I need to pass it a python-defined slot. That seems undoable.
> Until that is possible, it has to stay QDialog.
> 
> 

No one contradicts and AFAIK it is then your decision whether it is ready for moving or not.

But from my POV you should move it tonight. Then it should be included in weekly snapshot this week and tests by the wide mass can start.

Thanks.
Johannes