[Kde-games-devel] Review Request: New framework KGameRenderer (to be added to libkdegames)

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4283/
-----------------------------------------------------------

(Updated 2010-06-27 17:59:43.582301)


Review request for KDE Games.


Changes
-------

>From my POV, this diff is feature-complete for 4.6. (There are some more things which can be done, as indicated by the TODO comments in kgamerenderer.cpp, but that's just icing on the cake.)

The only new feature is the ability to disable some of the used optimization strategies. (This is only useful for very simple SVG themes like in Bovo).


Summary (updated)
-------

KGameRenderer is a small SVG->pixmap rendering framework for use in KDE games. I want to add it to libkdegames in the 4.6 cycle. For the story behind it, see http://kde.markmail.org/message/plfkwfeoni6nvpk2

Most important features:
- management of SVG themes (via KGameTheme and QSvgRenderer)
- reading of animated sprites (i.e. multiple SVG elements which are displayed one after the other to obtain an animation)
- multithreaded rendering
- two caching levels (in-process QHashes and shared KSharedDataCache)
- integration with QGraphicsView through the KGameRenderedItem class
- integrability with any existing implementations through the KGameRendererClient base class


Diffs (updated)
-----

  trunk/KDE/kdegames/libkdegames/CMakeLists.txt 1138526 
  trunk/KDE/kdegames/libkdegames/includes/CMakeLists.txt 1138526 
  trunk/KDE/kdegames/libkdegames/includes/KGameRenderedItem PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/includes/KGameRenderer PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/includes/KGameRendererClient PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/kgamerendereditem.h PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/kgamerendereditem.cpp PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/kgamerenderer.h PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/kgamerenderer.cpp PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/kgamerenderer_p.h PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/kgamerendererclient.h PRE-CREATION 
  trunk/KDE/kdegames/libkdegames/kgamerendererclient.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/4283/diff


Testing (updated)
-------

As part of a general refactoring, I have ported KDiamond to KGameRenderer in a local Git working branch which is available from git://git.bethselamin.de/kdegames-work.git (branch "kgamerenderer"). The port is stable and much faster, both in animation performance and startup time.


Thanks,

Stefan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100627/792f3aba/attachment.htm