[Kde-games-devel] Review Request: New classes KGameRenderer and KGameRenderedItem

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4283/
-----------------------------------------------------------

(Updated 2010-06-12 12:37:07.898754)


Review request for KDE Games.


Changes
-------

- Frame counts are also saved in the KSharedDataCache.
- The SVG renderer is instantiated only when needed, which is never if all pixmaps are in the cache already.
- The KGameRenderer::frameBaseIndex property has been introduced to support legacy themes.


Summary
-------

KGameRenderer is a small SVG->PNG rendering framework for use in KDE games. For the story behind it, see http://kde.markmail.org/message/plfkwfeoni6nvpk2

This diff reflects the current state of my local work branch: KGameRenderer is in a single source file inside the KDiamond source tree. I am in the process of porting KDiamond to KGameRenderer alongside writing KGameRenderer for testing reasons.

The relevant code is in the files "staging(-p)?.(h|cpp)". Eventually, KGameRenderer shall be moved inside libkdegames. I will take care of porting all applications in the kdegames module to KGameRenderer where it is fruitful.


Diffs (updated)
-----

  trunk/KDE/kdegames/kdiamond/src/CMakeLists.txt 1135863 
  trunk/KDE/kdegames/kdiamond/src/animator.cpp 1135863 
  trunk/KDE/kdegames/kdiamond/src/board.cpp 1135863 
  trunk/KDE/kdegames/kdiamond/src/diamond.h 1135863 
  trunk/KDE/kdegames/kdiamond/src/diamond.cpp 1135863 
  trunk/KDE/kdegames/kdiamond/src/mainwindow.cpp 1135863 
  trunk/KDE/kdegames/kdiamond/src/renderer.h 1135863 
  trunk/KDE/kdegames/kdiamond/src/renderer.cpp 1135863 
  trunk/KDE/kdegames/kdiamond/src/staging.h PRE-CREATION 
  trunk/KDE/kdegames/kdiamond/src/staging.cpp PRE-CREATION 
  trunk/KDE/kdegames/kdiamond/src/staging_p.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/4283/diff


Testing
-------

KDiamond still works, and even feels a bit faster although I have yet to fully take advantage of KGameRenderer's facilities.


Thanks,

Stefan