[Kde-games-devel] Review Request: Make libkcardgame public

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4251/#review6016
-----------------------------------------------------------


> CMakeLists.txt should install libkcardgame headers.

Why it "should"?
If the library is still in the kpat sources and its headers are not installed, it means it is not ready yet to be public;
what is your reason for wanting it public?

- Pino


On 2010-06-07 16:34:12, The-User wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4251/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 16:34:12)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> CMakeLists.txt should install libkcardgame headers.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kpat/libkcardgame/CMakeLists.txt 1135448 
>   trunk/KDE/kdegames/kpat/libkcardgame/include/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4251/diff
> 
> 
> Testing
> -------
> 
> works...
> 
> 
> Thanks,
> 
> The-User
> 
>