[Kde-games-devel] Review Request: Beveled piece edges for palapeli

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4608/#review6519
-----------------------------------------------------------

Ship it!


The changes I suggested are already included in the second revision of the patch, so everything's fine from my side.

- Stefan


On 2010-07-12 19:56:52, Johannes Löhnert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4608/
> -----------------------------------------------------------
> 
> (Updated 2010-07-12 19:56:52)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Adds runtime rendering of beveled edges to palapeli. The main worker functions are in piecevisuals.cpp. calculateBevelMap() returns a bevel map based on the transparency of the given pixmap. The bevelmap can be used for fast recalculation of the bevel effect (applyBevelMap()) when the piece is rotated. This anticipates that somewhen pieces will be rotatable.
> 
> I am quite sure the algorithms do their work :-) - however I am new to Qt and KDE guidelines, so the main point of the request lies on style and conformity.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/palapeli/src/engine/mergegroup.cpp 1149154 
>   trunk/KDE/kdegames/palapeli/src/engine/piece.h 1149154 
>   trunk/KDE/kdegames/palapeli/src/engine/piece.cpp 1149154 
>   trunk/KDE/kdegames/palapeli/src/engine/piecevisuals.h 1149154 
>   trunk/KDE/kdegames/palapeli/src/engine/piecevisuals.cpp 1149154 
>   trunk/KDE/kdegames/palapeli/src/engine/scene.h 1149154 
>   trunk/KDE/kdegames/palapeli/src/engine/scene.cpp 1149154 
> 
> Diff: http://reviewboard.kde.org/r/4608/diff
> 
> 
> Testing
> -------
> 
> Tested with a 400 piece puzzle. Memory usage and loading time increased moderately. I animated the bevel rerendering with a quick QTimer hack (not included), which showed realtime or near-realtime performance.
> 
> 
> Screenshots
> -----------
> 
> How it looks like
>   http://reviewboard.kde.org/r/4608/s/457/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100713/e13f5b9e/attachment.htm