[Kde-games-devel] Review Request: Kbreakout : Fixing the cursor to the moving bar

[Frederik Schwarzer]

> On 2010-01-22 18:36:22, Frederik Schwarzer wrote:
> > I tested the r5 patch and it seems to work fine. Is Fela (the maintainer) responding to emails?
> 
> Fabian Rami wrote:
>     No, he doesn't.
> 
> Frederik Schwarzer wrote:
>     Ok, I contacted him today. Let's see if I have more luck. If not, I will commit this in a few days or so.

So, I committed the patch. Can you please mark this review item as "done"?


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2446/#review3791
-----------------------------------------------------------


On 2009-12-27 23:41:52, Fabian Rami wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2446/
> -----------------------------------------------------------
> 
> (Updated 2009-12-27 23:41:52)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> When the bar stuck on to the side wall of the playing area, the cursor don't stuck and go away. 
> 
> When you want to come back to the other way, you have to wait that cursor come back to the bar before the bar start moving. 
> 
> I am a beginner in this kind of stuff ( review board, kde-contrib , etc ) so every critics are welcome. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbreakout/src/canvaswidget.h 1066752 
>   /trunk/KDE/kdegames/kbreakout/src/canvaswidget.cpp 1066752 
>   /trunk/KDE/kdegames/kbreakout/src/gameengine.h 1066752 
>   /trunk/KDE/kdegames/kbreakout/src/gameengine.cpp 1066752 
>   /trunk/KDE/kdegames/kbreakout/src/mainwindow.cpp 1066752 
> 
> Diff: http://reviewboard.kde.org/r/2446/diff
> 
> 
> Testing
> -------
> 
> There is no unit test for this project. 
> 
> I have played with that patch, the bar respond directly when you go off the side wall. 
> 
> 
> Thanks,
> 
> Fabian
> 
>