[Kde-games-devel] Review Request: Some wishes and fixes for kbounce

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3061/#review4292
-----------------------------------------------------------



/trunk/KDE/kdegames/kbounce/board.cpp
<http://reviewboard.kde.org/r/3061/#comment3784>

    Could you make these more descriptive?



/trunk/KDE/kdegames/kbounce/renderer.h
<http://reviewboard.kde.org/r/3061/#comment3785>

    Did you intent to document something here? :)


- Frederik


On 2010-02-26 16:10:29, Andreas Scherf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3061/
> -----------------------------------------------------------
> 
> (Updated 2010-02-26 16:10:29)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Added random background changing to kbounce. Wish: 221717
> And i fixed one issue of BUG:228063 were resizing did not pause the collision detection.
> And initial work for wish: 219507    	
> 
> 
> This addresses bugs 219507, 221717 and 228063.
>     https://bugs.kde.org/show_bug.cgi?id=219507
>     https://bugs.kde.org/show_bug.cgi?id=221717
>     https://bugs.kde.org/show_bug.cgi?id=228063
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbounce/CMakeLists.txt 1096082 
>   /trunk/KDE/kdegames/kbounce/backgroundselector.h PRE-CREATION 
>   /trunk/KDE/kdegames/kbounce/backgroundselector.cpp PRE-CREATION 
>   /trunk/KDE/kdegames/kbounce/backgroundselector.ui PRE-CREATION 
>   /trunk/KDE/kdegames/kbounce/ball.cpp 1096082 
>   /trunk/KDE/kdegames/kbounce/board.h 1096082 
>   /trunk/KDE/kdegames/kbounce/board.cpp 1096082 
>   /trunk/KDE/kdegames/kbounce/gamewidget.h 1096082 
>   /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1096082 
>   /trunk/KDE/kdegames/kbounce/kbounce.kcfg 1096082 
>   /trunk/KDE/kdegames/kbounce/mainwindow.h 1096082 
>   /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1096082 
>   /trunk/KDE/kdegames/kbounce/renderer.h 1096082 
>   /trunk/KDE/kdegames/kbounce/renderer.cpp 1096082 
>   /trunk/KDE/kdegames/kbounce/wall.cpp 1096082 
> 
> Diff: http://reviewboard.kde.org/r/3061/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/3061/s/322/
> 
>   http://reviewboard.kde.org/r/3061/s/323/
> 
> 
> Thanks,
> 
> Andreas
> 
>