[Kde-games-devel] Review Request: libkmahjongg: clear preview if no preview is available

[Frederik Schwarzer]

> On 2010-08-23 09:41:38, Stefan Majewsky wrote:
> > I have now committed as revision 1167011 a fix for this problem, and another problem that occurred to me: Because the background is technically not valid (no SVG is specified and can hence not be loaded), KMahjongg falls back to the default background in the first resize event after the change to the plain background.
> > 
> > Could you please test the changes in revision 1167011, and close this review then?

I cannot test it. I do not run trunk these days and I do not have time to set it up. Sorry


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3683/#review7163
-----------------------------------------------------------


On 2010-04-21 15:08:26, Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3683/
> -----------------------------------------------------------
> 
> (Updated 2010-04-21 15:08:26)
> 
> 
> Review request for KDE Games and Mauricio Piacentini.
> 
> 
> Summary
> -------
> 
> Go to 
> Settings -> Configure - KMahjongg -> Background
> and select a background image and then the Plain Color. The old image preview is still shown.
> 
> Comments?
> 
> 
> BTW: Would a description of the "color plain" background like "The default KDE window background color" be appropriate?
> 
> 
> This addresses bug 223450.
>     https://bugs.kde.org/show_bug.cgi?id=223450
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkmahjongg/kmahjonggbackgroundselector.cpp 1114177 
> 
> Diff: http://reviewboard.kde.org/r/3683/diff
> 
> 
> Testing
> -------
> 
> Tested in KMahjongg and KShisen.
> 
> 
> Thanks,
> 
> Frederik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100828/05240388/attachment.htm