[Kde-games-devel] Review Request: Port KBlocks to KGameRenderer

[Brian Croom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5081/
-----------------------------------------------------------

(Updated 2010-08-25 15:42:18.273262)


Review request for KDE Games, Mauricio Piacentini and Stefan Majewsky.


Changes
-------

This makes the requested changes, except for changing the background drawing method. I have spent several hours attempting to find a way to determine the proper size for the background pixmap, either from the view side or from the scene side, but have been unable to. If anyone has the solution that'd be great.


Summary
-------

This straightforward patch makes the KBlocks rendering code use KGameRenderer instead of making its own KGameTheme and QSvgRenderer instances


Diffs (updated)
-----

  /trunk/KDE/kdegames/kblocks/KBlocksGraphics.h 1167058 
  /trunk/KDE/kdegames/kblocks/KBlocksGraphics.cpp 1167058 
  /trunk/KDE/kdegames/kblocks/KBlocksItemGroup.cpp 1167058 
  /trunk/KDE/kdegames/kblocks/KBlocksScene.cpp 1167058 
  /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.h 1167058 
  /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.cpp 1167058 
  /trunk/KDE/kdegames/kblocks/main.cpp 1167058 

Diff: http://reviewboard.kde.org/r/5081/diff


Testing
-------

I have tested playing games and switching themes, and encountered no problems.


Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100825/e56950b7/attachment.htm