[Kde-games-devel] Review Request: Port Kollision to use KGameRenderer

[Brian Croom]

> On 2010-08-22 17:59:12, Stefan Majewsky wrote:
> > /trunk/KDE/kdegames/kollision/mainarea.cpp, line 43
> > <http://reviewboard.kde.org/r/5059/diff/2/?file=34117#file34117line43>
> >
> >     Shouldn't this be just m_renderer("pictures/theme.desktop")? KGameRenderer/KGameTheme is supposed to do the KStandardDirs stuff.

Ah, I see. Very nice.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5059/#review7155
-----------------------------------------------------------


On 2010-08-22 20:58:03, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5059/
> -----------------------------------------------------------
> 
> (Updated 2010-08-22 20:58:03)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch ports Kollision to use the KGameRenderer class for rendering balls.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kollision/CMakeLists.txt 1165385 
>   /trunk/KDE/kdegames/kollision/ball.h 1165385 
>   /trunk/KDE/kdegames/kollision/ball.cpp 1165385 
>   /trunk/KDE/kdegames/kollision/main.cpp 1165385 
>   /trunk/KDE/kdegames/kollision/mainarea.h 1165385 
>   /trunk/KDE/kdegames/kollision/mainarea.cpp 1165385 
>   /trunk/KDE/kdegames/kollision/pictures/CMakeLists.txt 1165385 
>   /trunk/KDE/kdegames/kollision/pictures/theme.desktop PRE-CREATION 
>   /trunk/KDE/kdegames/kollision/renderer.h 1165385 
>   /trunk/KDE/kdegames/kollision/renderer.cpp 1165385 
> 
> Diff: http://reviewboard.kde.org/r/5059/diff
> 
> 
> Testing
> -------
> 
> Everything seems to work.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100822/2337a18a/attachment-0001.htm