[Kde-games-devel] Review Request: Port KAtomic to use KGameRenderer

[Dmitry Suzdalev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4956/#review6961
-----------------------------------------------------------



/trunk/KDE/kdegames/katomic/fielditem.cpp
<http://reviewboard.kde.org/r/4956/#comment6998>

    Again, I'd suggest to make them "static QHash". more error proof :)
    
    Also I think it's better to make fillNameHashes private in AtomFieldItem() and do something like this:
    
    AtomFieldItem::AtomFieldItem()
    {
    if(s_names.isEmpty())
       fillNameHashes();
    }
    
    this would remove illogical responsibility of PlayField class for filling AtomFieldItem's essential properties.


- Dmitry


On 2010-08-10 14:53:31, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4956/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 14:53:31)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch ports KAtomic to use the KGameRenderer class instead its own renderer.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/katomic/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/katomic/default_theme.desktop PRE-CREATION 
>   /trunk/KDE/kdegames/katomic/fielditem.h 1161066 
>   /trunk/KDE/kdegames/katomic/fielditem.cpp 1161066 
>   /trunk/KDE/kdegames/katomic/katomicrenderer.h 1161066 
>   /trunk/KDE/kdegames/katomic/katomicrenderer.cpp 1161066 
>   /trunk/KDE/kdegames/katomic/main.cpp 1161066 
>   /trunk/KDE/kdegames/katomic/playfield.h 1161066 
>   /trunk/KDE/kdegames/katomic/playfield.cpp 1161066 
> 
> Diff: http://reviewboard.kde.org/r/4956/diff
> 
> 
> Testing
> -------
> 
> Everything seems to be working properly.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100810/3a9e2135/attachment-0001.htm