[Kde-games-devel] Review Request: libkmahjongg: clear preview if no preview is available

[Mauricio Piacentini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3683/#review5145
-----------------------------------------------------------


I need more time to review this. I believe this type of background (simple color) was never implemented in the code, but my memory is fuzzy about this. Frederik, does it work (the single color background) for you at all?

- Mauricio


On 2010-04-21 15:08:26, Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3683/
> -----------------------------------------------------------
> 
> (Updated 2010-04-21 15:08:26)
> 
> 
> Review request for KDE Games and Mauricio Piacentini.
> 
> 
> Summary
> -------
> 
> Go to 
> Settings -> Configure - KMahjongg -> Background
> and select a background image and then the Plain Color. The old image preview is still shown.
> 
> Comments?
> 
> 
> BTW: Would a description of the "color plain" background like "The default KDE window background color" be appropriate?
> 
> 
> This addresses bug 223450.
>     https://bugs.kde.org/show_bug.cgi?id=223450
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkmahjongg/kmahjonggbackgroundselector.cpp 1114177 
> 
> Diff: http://reviewboard.kde.org/r/3683/diff
> 
> 
> Testing
> -------
> 
> Tested in KMahjongg and KShisen.
> 
> 
> Thanks,
> 
> Frederik
> 
>