[Kde-games-devel] Review Request: Demo mode in Kiriki

[Luiz Romário Santana Rios]

> On 2010-04-12 20:00:54, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/row.cpp, lines 12-17
> > <http://reviewboard.kde.org/r/3573/diff/2/?file=23236#file23236line12>
> >
> >     You are correct that using an initialiser list is a good idea here, but this change is unrelated to the original goal of this patch.
> >     
> >     Please try to keep each patch down to a single bug fix, feature, or improvement as it makes reviewing much easier and keeps the VCS history cleaner. Six ten line patches are generally much preferred to one thirty line patch.
> 
> Luiz Romário Santana Rios wrote:
>     Okay, but what should I do? Send a patch only for this?
> 
> Parker Coates wrote:
>     Since this change doesn't make a big difference, normally you would just silently fix it yourself. But as a new contributor without SVN access, that's not so easy. :) I'll just submit this part of the patch for you, if you don't mind.

Please do it.


- Luiz Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3573/#review4987
-----------------------------------------------------------


On 2010-04-13 13:36:37, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3573/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 13:36:37)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements demonstration game in Kiriki.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/configPage.ui 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1113356 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1113356 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1113356 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1113356 
> 
> Diff: http://reviewboard.kde.org/r/3573/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>