[Kde-games-devel] Review Request: Demo mode in Kiriki

Parker Coates parker.coates at kdemail.net
Tue Apr 13 14:47:05 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3573/#review5005
-----------------------------------------------------------


More minor nitpicks.


/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3573/#comment4498>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3573/#comment4499>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3573/#comment4497>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3573/#comment4496>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://reviewboard.kde.org/r/3573/#comment4495>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/lateralwidget.h
<http://reviewboard.kde.org/r/3573/#comment4492>

    Move the implementation to the cpp.



/trunk/KDE/kdegames/kiriki/src/lateralwidget.h
<http://reviewboard.kde.org/r/3573/#comment4493>

    This method is unnecessary and should be removed.



/trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp
<http://reviewboard.kde.org/r/3573/#comment4491>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp
<http://reviewboard.kde.org/r/3573/#comment4490>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp
<http://reviewboard.kde.org/r/3573/#comment4489>

    Code formatting.



/trunk/KDE/kdegames/kiriki/src/main.cpp
<http://reviewboard.kde.org/r/3573/#comment4487>

    Unnecessary change.


- Parker


On 2010-04-13 10:18:52, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3573/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 10:18:52)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements demonstration game in Kiriki. Almost complete.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/configPage.ui 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1113356 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1113356 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1113356 
>   /trunk/KDE/kdegames/kiriki/src/main.cpp 1113356 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1113356 
> 
> Diff: http://reviewboard.kde.org/r/3573/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>



More information about the kde-games-devel mailing list