[Kde-games-devel] Review Request: Demo mode in Kiriki

[Luiz Romário Santana Rios]

> On 2010-04-12 20:00:54, Parker Coates wrote:
> > Hello, Luiz. Thanks for the patch. Below are some issues I found while reading through the patch. (I haven't actually tested it yet.) There are quite a few points below, but please don't be discouraged. If you have any questions, feel free to ask.

OK.


> On 2010-04-12 20:00:54, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.cpp, lines 78-80
> > <http://reviewboard.kde.org/r/3573/diff/2/?file=23233#file23233line78>
> >
> >     Does this code actually work as expected? Once the action has been disabled, how does it ever get re-enabled?

Yes, because of the second connect: when a new game is started, gameNewAction emits triggered(false). Thus, the demo action gets enabled.


> On 2010-04-12 20:00:54, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.h, line 48
> > <http://reviewboard.kde.org/r/3573/diff/2/?file=23232#file23232line48>
> >
> >     This variable isn't actually needed. Instead of setting m_justStarted in the constructor and checking it in every time newGame() is called, just check the setting at the end of the constructor and call either demo() or newGame() accordingly.

I'll check this.


> On 2010-04-12 20:00:54, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg, lines 19-21
> > <http://reviewboard.kde.org/r/3573/diff/2/?file=23234#file23234line19>
> >
> >     I'm not sure if enabling this by default is a good idea or not. I think it could be confusing for user if they don't realise that it's a demo that they're seeing. The might sit there waiting for "their" turn, which will never come. ;)

I was thinking of showing the user that the game is a demo - maybe like in Kubrick. Would it be better?


> On 2010-04-12 20:00:54, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.cpp, lines 188-190
> > <http://reviewboard.kde.org/r/3573/diff/2/?file=23233#file23233line188>
> >
> >     I'm not sure this is a good idea. After finishing a game, I would not expect a new demo to start after 3 seconds without warning. I could see this being quite confusing to users.

A demo will start only if the current game is also a demo.


- Luiz Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3573/#review4987
-----------------------------------------------------------


On 2010-04-12 17:53:41, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3573/
> -----------------------------------------------------------
> 
> (Updated 2010-04-12 17:53:41)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements demonstration game in Kiriki. Almost complete.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/configPage.ui 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1113356 
>   /trunk/KDE/kdegames/kiriki/src/kirikiui.rc 1113356 
>   /trunk/KDE/kdegames/kiriki/src/row.cpp 1113356 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1113356 
> 
> Diff: http://reviewboard.kde.org/r/3573/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>