[Kde-games-devel] KBounce changes

[Parker Coates]

On Mon, Apr 12, 2010 at 07:47, Andreas Scherf wrote:
> 2010/4/12 Frederik Schwarzer
>> [Andreas Scherf - Montag 12 April 2010 00:49:22]
>> > Am Montag, 12. April 2010 schrieb Frederik Schwarzer:
>> > > [Andreas Scherf - Dienstag 06 April 2010 22:35:02]
>> > >
>> > > > Hello,
>> > > > again i made some changes in kbounce.
>> > > > I added the "geme over" sound again.
>> > > > But there is something weird with the Phonon backend. I looked into
>> > > > some
>> > > > othewr games and some used two Phonon backends to play sounds. Each
>> > > > time
>> > > > the game ask the backend for the delay or the state. Is there a
>> > > > class in
>> > > > the libs planned for correct sound handling?
>> > > >
>> > > > After that  i added the themed overlay drawing if a background is
>> > > > inside
>> > > > the theme.
>> > > >
>> > > > Any comments?
>> > >
>> > > In case nothing happened yet ...
>> > > You might want to put these to reviewboard again. On mailing lists
>> > > topics are burried so easily.
>> > > Please split your changes to logical pieces. That makes it easier
>> > > to review them.
>> > Ok. I will do. The main changes are some rendering changes for the
>> > overlay
>> > screen and the sound for loosing a live. I think this are smal changes
>> > and it
>> > is hard to wait for each change some weeks to get the "OK" for commit on
>> > the
>> > review board. I would like to improve the rendering in some steps but at
>> > the
>> > moment each change took weeks until i got the ok. Thats dissapointing.
>> > I splitt things up and post them on the reviewboard.
>>
>> Was taking over maintainership already discussed? I think if your
>> intention is to improve and maintain KBounce, you should not be
>> forced to go over reviewboard for every change.
>
> Yes, i mentioned that before. I would take maintainership for kbounce.
> But on large changes it would be helpfull to use the review board.
> Who has to be informed about maintainership changes?

Sadly, the KDEGames team is very active at the moment, so the truth
is, even those of us who read your requests might not have time to do
an actual review. Sad, but true.

This list is really the only place that needs notified. Oh, and you
should update http://techbase.kde.org/Projects/Games/Maintainers. I
would say, go for it. For smaller bug fixes or polish, feel free to
commit directly to SVN (if you're comfortable with that). For feature
additions or behavioural changes, sticking the patch on ReviewBoard
for a few days is probably best.

Parker