[Kde-games-devel] How do you play jigsaw puzzles

[Alexander Neundorf]

On Wednesday 21 October 2009, Matthew Woehlke wrote:
> Stefan Majewsky wrote:
> > Am Mittwoch 21 Oktober 2009 00:28:25 schrieb Parker Coates:
> >> I think a solution as was mentioned here would make sense for games in
> >> playground:
> >>
> >> http://markmail.org/message/s7bd2eaaqnm46vbv
> >>
> >> If Matthew's additions were surrounded by a guard as shown there, you
> >> could drop the dependence on the module while still doing the right
> >> thing when being built as part of the module. Of course if you'd
> >> rather keep your CMakeLists.txt clean, than I can understand that too.
> >
> > If the buildsystem guys agree with that solution (and they do
> > apparently), I'm fine with it too. Just one note on the patch: You can
> > remove the libkdegames stuff. I'm not depending on it.
>
> Okay, so any objection if I commit this?
>
> (Buildsystem folk, this is for playground/games/palapeli.)
>
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt      (revision 1038078)
> +++ CMakeLists.txt      (working copy)
> @@ -1,5 +1,14 @@
>   project(palapeli)
>
> +if (NOT KDE4_FOUND)
> +  find_package(Qt4 REQUIRED)
> +  find_package(KDE4 REQUIRED)
> +
> +  include_directories(${KDE4_INCLUDES})
> +
> +  include(KDE4Defaults)
> +endif (NOT KDE4_FOUND)
> +
>   add_subdirectory(libpala)
>   add_subdirectory(cmake)

I had a look, please remove the 
add_subdirectory(cmake) and please don't install FindLibPala.cmake.

Installing a FindFOO.cmake file together with package FOO doesn't make sense, 
since then FindFOO.cmake is only present when FOO is present, when FOO is not 
present or not found, also FindFOO.cmake is not present or not found, so this 
does not help.

If you really want to install that file (do you really want to do that ? It 
means you should try to keep compatibility), you could install a 
LibPalaConfig.cmake file e.g. in lib/cmake/LibPala/, see the documentation 
for FIND_PACKAGE() in config-mode for details.

Alex