[Kde-games-devel] Review Request: KScoreDialog with level selection

[Felix Lemke]

> On 2009-10-01 22:33:33, Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h, line 200
> > <http://reviewboard.kde.org/r/1743/diff/2/?file=12252#file12252line200>
> >
> >     What do you need the translated name for here?

The level will automatically added to the list of level names. And in this list the untranslated name is used as identifier and the translated name as string to show.


> On 2009-10-01 22:33:33, Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h, line 185
> > <http://reviewboard.kde.org/r/1743/diff/2/?file=12252#file12252line185>
> >
> >     The example is wrong, ki18n does not return a QString

Sorry, it should be i18n(), not ki18n().


> On 2009-10-01 22:33:33, Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp, line 63
> > <http://reviewboard.kde.org/r/1743/diff/2/?file=12253#file12253line63>
> >
> >     KComboBox

I'll change it.


> On 2009-10-01 22:33:33, Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h, line 182
> > <http://reviewboard.kde.org/r/1743/diff/2/?file=12252#file12252line182>
> >
> >     levelnames -> level names
> >     Here and in more places

I hope, I found all.


> On 2009-10-01 22:33:33, Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp, line 213
> > <http://reviewboard.kde.org/r/1743/diff/2/?file=12253#file12253line213>
> >
> >     This is quite innefficient, i know the other functions are coded the same way, but could you do it the proper way, that is using an iterator?

I changed it also for addLocalizedConfigGroupNames(...)


> On 2009-10-01 22:33:33, Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h, line 183
> > <http://reviewboard.kde.org/r/1743/diff/2/?file=12252#file12252line183>
> >
> >     add -> adds
> >     Here and in more places

Done


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1743/#review2516
-----------------------------------------------------------


On 2009-10-01 13:08:20, Felix Lemke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1743/
> -----------------------------------------------------------
> 
> (Updated 2009-10-01 13:08:20)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Hi,
> 
> in KSpiral I need a different height-score for each level. For this I've patched the KScoreDialog. I've tested the KScoreDialog in different games (like kdiamond, kbounce, knetwalk) and I think it's fully backwards compatible. Now there are three new functions:
>  - addLocalizedLevelName(QPair<QByteArray, QString> level): with this you can add an level to the dialog. If the list of level isn't empty above the tabwidget is a QComboBox shown, where you can choose the level.
> 
>  - addLocalizedLevelNames(QMap<QByteArray, QString> level): nearly the same like the function above, but you can add more than one level at once.
> 
>  - setLevelName: to read or write the config belonging to your level you need to set the current level name. In the rc-file of your application the groupname is changed from KHightScore_GameDifficulty to KHighScore_GameDifficulty_MAP:levelname.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1029697 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1029697 
> 
> Diff: http://reviewboard.kde.org/r/1743/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> new KScoreDialog with level selection
>   http://reviewboard.kde.org/r/1743/s/214/
> 
> 
> Thanks,
> 
> Felix
> 
>