[Kde-games-devel] KPat Progress and Regressions

[Aaron J. Seigo]

On November 16, 2009, Parker Coates wrote:
> - The code style doesn't match the rest of the file. Curly braces
> should be on their own lines. Parentheses should be padded with
> spaces. Nothing major.

i will that up before committing...
 
> - The 50 ms and the 0.2 increment are repeated in several place. Could
> we instead define these as constants calculated at compile time from
> the desired animation duration and the number of frames?

yes, that's easy to do. i'll add it to the times header.
 
> Does this produce different/better/worse code than "qBound<qreal>(
> 0.0, m_highlightFadeAmount, 1.0 );" or "qBound<qreal>( 0,
> m_highlightFadeAmount, 1 );"

it's not better/worse code, i'm just in the happen of wrapping qreals because 
on ARM they are not the same as on x86 and it causes fun and odd compile 
errors when comparing qreals and non-cast literals. 0 is an exception, it 
seems to work no matter what :) 

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20091116/a7c4dc90/attachment.sig