[Kde-games-devel] Review Request: Fix Qt-4.6 regressions in Konquest

[Dmitry Suzdalev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2079/
-----------------------------------------------------------

(Updated 2009-11-05 22:24:12.388708)


Review request for KDE Games.


Summary (updated)
-------

This patch fixes the following regressions which I discovered when running Konquest with 4.6:

1. Calling QGS::width() or QGS::height() from some QGraphicsItem::boundingRect() reimplementation will cause an endless loop.
This happens because QGS::width() calls QGS::itemsBoundingRect() which again calls QGraphicsItem::boudnignRect() => voila :)
Solution: cache scene width and height in local variables.

2. Somehow having QGV with enabled CacheBackground flag causes the background to be drawn as a black pixmap.
Use a workaround found by Parker for that.


Diffs (updated)
-----

  trunk/KDE/kdegames/konquest/mapscene.h 978893 
  trunk/KDE/kdegames/konquest/mapscene.cc 978893 
  trunk/KDE/kdegames/konquest/mapview.cc 978893 

Diff: http://reviewboard.kde.org/r/2079/diff


Testing
-------

Locally tested - Konquest doesn't crash at startup with Qt-4.6 and displays background correctly


Thanks,

Dmitry