[Kde-games-devel] Review Request: Bomber: Trivial patches

[John-Paul Stanford]

Hi,

Just took a look at your patch. Looks good. Intresting looking at the
changes, were you added the const *,
did not know abou that (I'm come for a java background).

Cheers,
JP.

-----Original Message-----
From: Omer F. USTA [mailto:omerusta at gmail.com] 
Sent: 16 May 2009 5:58 AM
To: Omer F. USTA; KDE Games
Subject: [Kde-games-devel] Review Request: Bomber: Trivial patches


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/709/
-----------------------------------------------------------

Review request for KDE Games.


Summary
-------

Some forgetten const s at getter functions added,
a typo at /* */ changed to /** */,
a forgetten return information added into /** */,
some statements moved into .cpp from .h to make whole code
same syntax.


Diffs
-----

  trunk/KDE/kdegames/bomber/src/bomberwidget.h 968548 
  trunk/KDE/kdegames/bomber/src/bomberwidget.cpp 968548 
  trunk/KDE/kdegames/bomber/src/building.h 968548 
  trunk/KDE/kdegames/bomber/src/building.cpp 968548 
  trunk/KDE/kdegames/bomber/src/explodable.h 968548 
  trunk/KDE/kdegames/bomber/src/explodable.cpp 968548 
  trunk/KDE/kdegames/bomber/src/renderer.h 968548 
  trunk/KDE/kdegames/bomber/src/renderer.cpp 968548 

Diff: http://reviewboard.kde.org/r/709/diff


Testing
-------


Thanks,

Omer F.

_______________________________________________
kde-games-devel mailing list
kde-games-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel