[Kde-games-devel] Review Request: Bomber: Trivial patches

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/709/#review1146
-----------------------------------------------------------

Ship it!


Looks good to me. The implementation of BomberGameWidget::state() could use some line breaks and indentation to be consistent with the rest of the code, though.

- Parker


On 2009-05-15 21:58:11, Omer F. USTA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/709/
> -----------------------------------------------------------
> 
> (Updated 2009-05-15 21:58:11)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Some forgetten const s at getter functions added,
> a typo at /* */ changed to /** */,
> a forgetten return information added into /** */,
> some statements moved into .cpp from .h to make whole code
> same syntax.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.h 968548 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.cpp 968548 
>   trunk/KDE/kdegames/bomber/src/building.h 968548 
>   trunk/KDE/kdegames/bomber/src/building.cpp 968548 
>   trunk/KDE/kdegames/bomber/src/explodable.h 968548 
>   trunk/KDE/kdegames/bomber/src/explodable.cpp 968548 
>   trunk/KDE/kdegames/bomber/src/renderer.h 968548 
>   trunk/KDE/kdegames/bomber/src/renderer.cpp 968548 
> 
> Diff: http://reviewboard.kde.org/r/709/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Omer F.
> 
>