[Kde-games-devel] Review Request: Kapman: Various trivial patches
    Omer F. USTA 
    omerusta at gmail.com
       
    Sun May  3 03:57:42 CEST 2009
    
    
  
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/657/
-----------------------------------------------------------
Review request for KDE Games.
Summary
-------
pill.cpp/.h :
  + Change to Proper values instead a hardcoded values
kapmanparser.cpp/.h :
  + some of if statements converted to else if statements
kapmanmainwindow.cpp/.h :
  + gameview.h double included (one of them in .cpp, another in .h )
ghost.cpp/.h :
  + Ghost::POINTS const int value added and make it equals to 200
  + Change to Proper values instead a hardcoded values
cell.cpp/.h :
  + 2 Forgetten const functions for getter func.
game.cpp/.h :
  + Forgetten const functions for getter func.
Diffs
-----
  trunk/KDE/kdegames/kapman/pill.cpp 962714 
  trunk/KDE/kdegames/kapman/kapmanparser.cpp 962714 
  trunk/KDE/kdegames/kapman/kapmanmainwindow.cpp 962714 
  trunk/KDE/kdegames/kapman/ghost.cpp 962714 
  trunk/KDE/kdegames/kapman/ghost.h 962714 
  trunk/KDE/kdegames/kapman/game.cpp 962714 
  trunk/KDE/kdegames/kapman/game.h 962714 
  trunk/KDE/kdegames/kapman/cell.cpp 962714 
  trunk/KDE/kdegames/kapman/cell.h 962714 
Diff: http://reviewboard.kde.org/r/657/diff
Testing
-------
Thanks,
Omer F.
    
    
More information about the kde-games-devel
mailing list