[Kde-games-devel] Review Request: In this patch i have addet a method to drop blocks completely down. I have changed the CMakeLists.txt that i can compile Kblocks here.I wanted to remove the change to CMakeLists.txt, but i could not change the diff without leading the server to fail. This is my first Patch for kde =)

[Albert Astals Cid]

> On 2009-03-11 16:37:06, Albert Astals Cid wrote:
> > I'm not the maintainer, so you wait for Mauricio's comments, in general it seems okaish to me from my "i don't know anything about kblocks" perspective. Also you are adding a new include that seems not necessary.
> 
> Dirk Leifeld wrote:
>     You are right. it is not nessesary.
> 
> Mauricio Piacentini wrote:
>     Other than removing the KGameDifficulty include, everything seems ok. Can you commit it?
> 
> Dirk Leifeld wrote:
>     I don't have a svn akkount yet. I'll apply for one.

has this been commited?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/275/#review456
-----------------------------------------------------------


On 2009-03-11 16:25:36, Dirk Leifeld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/275/
> -----------------------------------------------------------
> 
> (Updated 2009-03-11 16:25:36)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Now we can drop blocks all the way down with one keystroke.
> 
> 
> This addresses bug 162529.
>     https://bugs.kde.org/show_bug.cgi?id=162529
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kblocks/kblocksview.cpp 937533 
>   /trunk/KDE/kdegames/kblocks/kblocksview.h 937533 
>   /trunk/KDE/kdegames/kblocks/kblocksscene.h 937533 
>   /trunk/KDE/kdegames/kblocks/kblocksscene.cpp 937533 
>   /trunk/KDE/kdegames/kblocks/kblocks.cpp 937533 
> 
> Diff: http://reviewboard.kde.org/r/275/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dirk
> 
>