[Kde-games-devel] Review Request: Redeal disabled hidden after redealPossible(false) emitted
Matthias Fuchs
mat69 at gmx.net
Mon Mar 16 22:48:45 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/346/
-----------------------------------------------------------
Review request for KDE Games.
Summary
-------
My patch fixes the mentioned bug. It also leads to "Hint" and "Demo" being disabled when no moves are possible anymore.
I hope that this adds no regression (don't think though), as I'm not sure why all the connects were in setScene initially instead of setupActions.
Please only answer on rb, as I'm not following the kdegames ml.
This addresses bug 185439.
https://bugs.kde.org/show_bug.cgi?id=185439
Diffs
-----
/trunk/KDE/kdegames/kpat/view.cpp 940198
Diff: http://reviewboard.kde.org/r/346/diff
Testing
-------
Tested a little bit on 4.2 branch and trunk.
Thanks,
Matthias
More information about the kde-games-devel
mailing list