[Kde-games-devel] Review Request: Fix usage of KScoreDialog in KDiamond

Parker Coates parker.coates at gmail.com
Sun Mar 15 22:11:56 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/336/#review487
-----------------------------------------------------------

Ship it!


Seems like a straight forward fix to me. Not my app, but I would say ship it.

- Parker


On 2009-03-15 14:08:37, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/336/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 14:08:37)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Add proper calls to set i18n and weigths of default difficulty levels
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kdiamond/src/mainwindow.cpp 939824 
> 
> Diff: http://reviewboard.kde.org/r/336/diff
> 
> 
> Testing
> -------
> 
> Without it Catalan Fàcil is shown as "F~ cil" or something like that, with them it works
> 
> 
> Thanks,
> 
> Albert
> 
>



More information about the kde-games-devel mailing list