[Kde-games-devel] Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.

Jaime Torres jtamate at gmail.com
Thu Jul 30 20:13:26 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/947/
-----------------------------------------------------------

(Updated 2009-07-30 18:13:26.351374)


Review request for KDE Games and usability.


Changes
-------

New version, tested with killbots, kollision and ktron.
Pressing Remember does as before except that:
  * deletes the lowest highscore
  * changes the button to close
  * deletes the congratulations (I'm not sure about this).
Pressing Enter in the textedit behaves as pressing Remember, except that the dialog is not closed.
Pressing Forget:
  * deletes the newest highscore
  * changes the button to close
  * deletes the congratulations (I'm sure about this).


Summary
-------

Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel.


Diffs (updated)
-----

  /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 
  /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 

Diff: http://reviewboard.kde.org/r/947/diff


Testing
-------

The dialog works as before.


Thanks,

Jaime



More information about the kde-games-devel mailing list