[Kde-games-devel] Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.

[Parker Coates]

> On 2009-07-15 07:01:02, Anne-Marie Mahfouf wrote:
> > Maybe this should be submitted to the Usability Reviewboard group.
> 
> Albert Astals Cid wrote:
>     Makes no sense sending it to the usability mailing list while the code is wrong, Jaime are you going to answer to my comment or what?
> 
> Jaime Torres wrote:
>     Albert, just one line before the diffs shown in the reviewboard there is already an:
>     if (askName)
>     {
>     ... set button names.
>     }
> 
> Albert Astals Cid wrote:
>     Lol, right, now Parker can you tell us why you think it does not work at?

Argh! I just realised you have to manually "Publish" your comments on ReviewBoard. Albert, I was about to tell you to pay more attention and read what I had written in an earlier comment, when I noticed the little green "This reply is a draft" bar just above it. It's been sitting there, unseen by anyone for the last 13 days. Sigh. I'll click that "Publish" button now. Sorry for holding up the process.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/947/#review1611
-----------------------------------------------------------


On 2009-07-15 07:23:47, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/947/
> -----------------------------------------------------------
> 
> (Updated 2009-07-15 07:23:47)
> 
> 
> Review request for KDE Games and usability.
> 
> 
> Summary
> -------
> 
> Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 953006 
> 
> Diff: http://reviewboard.kde.org/r/947/diff
> 
> 
> Testing
> -------
> 
> The dialog works as before.
> 
> 
> Thanks,
> 
> Jaime
> 
>