[Kde-games-devel] Tiles in KShisen

[Frederik Schwarzer]

On Monday 19 January 2009 16:44:08 Mauricio Piacentini wrote:
> Frederik Schwarzer wrote:
> > Hi,
> > 
> > I had a look at the KShisen bugreports and there are two issues that are
> > caused by the tile sharing with kmahjong. Or at least it seems so in my
> > untrained eyes. :)
> > 
> > 1. the border is broader than the one in the kde 3 version
> > Related report: http://bugs.kde.org/show_bug.cgi?id=156645
> > As I can see it the border (or rather the size of the tile grid) is
> > calculated through the preferredTileSize() method than comes from
> > libkmahjongg/kmahjonggtileset.h
> > Having a border that wide is fine in KMahjong. In KShisen though it
> > looks a bit unfortunate if you are playing a large grid.
> > What would be a "clean" way to shrink the border for large grids in
> > KShisen?
> 
> I looked at preferredTileSize() and I think it is doing the right thing: 
> you pass the boardsize to it, and it tries to find the maximum size of 
> the tiles that will fit this area and maintain the proportion. But of 
> course it might be buggy: how big is the border you are seeing? Is the 
> smaller border (width or height one) larger than one tile?

No, the smaller border is a bit smaller than one tile at the top and
the bottom and kind of the size of a tile on the left and the right.
It's a rather personal feeling that the extra inch might be nice when
playing in the largest grid. :)

Regards