[Kde-games-devel] KSudoku patch for bug 171462

[Albert Astals Cid]

A Dilluns 12 Gener 2009, Mauricio Piacentini va escriure:
> Johannes Bergmeier wrote:
> > I'm sorry to fix this bug that late. As it requires changes in multiple
> > files including artwork I want to ask for review and permission to apply
> > this patch.
> >
> > The problem was the missing support of values greater than 9 in the new
> > rendering code and artwork. I added the required artwork to all themes
> > and the necessary code to the renderer and the value-selection-list.
> >
> > As this can be considered a show stopper bug I want to fix it before 4.2.
> > If no one disagrees I will commit this patch in the next few days.
>
> There are no new strings or artwork, so I think the patch should be
> allowed. The code changes look straightforward for someone like me not
> familiar with Ksudoku's internals. Wait until tomorrow though so Albert
> or Matt who are more experienced with release issues can comment on it.

Yeah, it's ok to commit to KDE 4.2 branch if you think it fixes more thing 
than it breaks :D

Albert

>
> Regards,
> Mauricio Piacentini
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel