[Kde-games-devel] kmines

[Clemens Werther]

On 2/6/09, Albert Astals Cid <aacid at kde.org> wrote:
> A Divendres, 6 de febrer de 2009, Clemens Werther va escriure:
>> -- proper_first_click.diff
>> Put the "first-click-detection" routine where it belongs.
>>
>> -- mid_and_left_click.diff
>> Actually, this fixes two problems, but as it doens't make sense to fix
>> just one of those two issues, I put it all in one diff file.
>> 1)
>> press left; press mid; release left; release mid
>> This results in a pressed item, altough the mouse is not pressed anymore.
>>
>> 2)
>> press left; press mid; release left; move mouse over another cell;
>> press left; release mid; release left
>> The timer starts, altough no item is revealed (only really visible
>> after patching with proper_first_click.diff, because without, the
>> timer even starts when any mouse button is pressed... ).
>>
>> This patch fixes both issues,
>> but actually, it is useless, as long as the source isn't patched with
>> proper_first_click.diff.
>
> Patches are missing, also it would be a good idea if you used the
> reviewboard.
>
> Albert
>
>>
>> Clemens
>> _______________________________________________
>> kde-games-devel mailing list
>> kde-games-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kde-games-devel
>
>
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
>
strange...
I was sure, I attached them.

What do you mean with "reviewboard"? bug.kde.org?

Clemens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: proper_first_click.diff
Type: text/x-patch
Size: 981 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20090208/2db68188/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mid_and_left_click.diff
Type: text/x-patch
Size: 785 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20090208/2db68188/attachment-0001.diff