[Kde-games-devel] Review Request: (test review) This is not a member variable, right?

Parker Coates parker.coates at gmail.com
Wed Feb 4 21:20:55 CET 2009



> On 2009-02-04 12:18:17, Parker Coates wrote:
> > Adding "m_" to local variables can lead to nothing but confusion. I approve of this patch.

Apparently, I should have clicked the "Ship it!" box.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/24/#review13
-----------------------------------------------------------


On 2009-02-04 12:16:09, Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/24/
> -----------------------------------------------------------
> 
> (Updated 2009-02-04 12:16:09)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This is just a test review. However, the question is real: only member variables are prepended with m_ (if the author decided to choose this naming scheme), right?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kapman/game.cpp 921326 
> 
> Diff: http://reviewboard.kde.org/r/24/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik
> 
>



More information about the kde-games-devel mailing list