[Kde-games-devel] Review Request: Kbreakout : Fixing the cursor to the moving bar

Fabian Rami fab.rami at gmail.com
Mon Dec 28 00:41:52 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2446/
-----------------------------------------------------------

(Updated 2009-12-27 23:41:52.742524)


Review request for KDE Games.


Changes
-------

I hope it's the last :) 


Summary
-------

When the bar stuck on to the side wall of the playing area, the cursor don't stuck and go away. 

When you want to come back to the other way, you have to wait that cursor come back to the bar before the bar start moving. 

I am a beginner in this kind of stuff ( review board, kde-contrib , etc ) so every critics are welcome. 


Diffs (updated)
-----

  /trunk/KDE/kdegames/kbreakout/src/canvaswidget.h 1066752 
  /trunk/KDE/kdegames/kbreakout/src/canvaswidget.cpp 1066752 
  /trunk/KDE/kdegames/kbreakout/src/gameengine.h 1066752 
  /trunk/KDE/kdegames/kbreakout/src/gameengine.cpp 1066752 
  /trunk/KDE/kdegames/kbreakout/src/mainwindow.cpp 1066752 

Diff: http://reviewboard.kde.org/r/2446/diff


Testing
-------

There is no unit test for this project. 

I have played with that patch, the bar respond directly when you go off the side wall. 


Thanks,

Fabian



More information about the kde-games-devel mailing list