[Kde-games-devel] kblocks single game new implementation...

[Dapeng Zhang]

Hi Mauricio,

We are going to check a) b) and c) as soon as possible. Many thanks for 
your testing.

For d), of course the original author(s) should be listed. Actually, I 
got some support from the University. A student is doing the coding job. 
He doesn't notice the copyright issue, and only listed himself. This is 
of course wrong.

Yes, I'm planning to stay around as a maintainer.  There will be a 
"formal" version in svn by the end of Jan... So far, the source package 
in svn is only a start of the student.

It would be very nice if you could stay around, giving comments and so on...

best...

dapeng

Mauricio Piacentini wrote:
> a) When you change difficulty, the game does not warn you that it will
> be terminated, as the original KBlocks. You can switch from one to
> another to test: start a game, select a new difficulty on the status
> bar to test.
>
> b) There is no message when you pause or resume a game. Also, the
> state of the buttons in the interface is confused when you pause for
> example and start a new one using the difficulty popup. I think this
> is related to issue a somehow.
>
> c) There is a caching problem with SVG elements and switching themes.
> To test, start a game. Then go to configure and switch from egyptian
> to oxygen, or vice-versa. Some element will not be updated. If you
> scale the window then everything will be right. Tip: I believe this is
> the old issue when you put elements in cache just with the name and
> dimensions as keys, it might be good to add the theme name as well (I
> believe we did this on KMines a while ago)
>
> d) Copyright information on some files is not quite right. I would
> prefer if you keep the copyright of the original author (me) and add
> yours on a second line. I understand you probaby started a new
> template project and some of this info was lost, no biggie.
>
> As for replacing the current KBlocks with this one after 4.4 ships: I
> would agree with this if you take over maintainership for this code,
> maybe with someone as a backup. I ask you to take over maintainership
> as I feel that the current code is easier for me to maintain: it has
> no known bugs, fewer files, fewer classes, and I do not mind the
> logic/presentation mix for simple games like this, which was supposed
> to be single player only by design. This has maybe to do with my
> background, which is not in computer science or engineering.
>
> So, hard question :) Are you planning to stay around at least until
> 4.6 ships, and take care of KBlocks until then? If you are, then
> welcome! I believe you just need to correct the issues above and then
> you can move the refactoring to trunk after 4.4 ships, and start
> implementing your AI and multiplayer ideas as well.
>
> People, comments?
>
> Best regards,
> Mauricio Piacentini
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
>