[Kde-games-devel] KDE/kdegames/libkdegames

[Albert Astals Cid]

----- Mensaje original -----
> SVN commit 868325 by coates:
>
> Fixed and cleaned up logic for selecting the last used theme.

To be sincere i don't see how this can fix the problem as its the same written in a different way

>
> For some reason, selecting the last used theme recently stopped working
> for some games if the theme was the default one. I'm not sure, but
> this might be related to aseigo's changes to KConfigSkeleton and default
> values.
>
> Regardless the new code should work the same as before, with the added
> bonus that the "Theme" KConfig entry is no longer hardcoded to the
> "General" group. As long as it's named "Theme", it will be found
> automatically.

I do no see why this is a bonus at all, groups are there for a reason, and you ignoring them can introduce subtle bugs, like i for example having a Theme entry in my Sounds group

Unless you have a strong reason please revert that.

Albert

>
> There is still a potential issue when running a game for the first time.
> As a game developer there are a couple things you can do to prevent
> this. One is to set the default value of the "Theme" entry to "themes/
> default.desktop" (or whatever your default theme is named). The other is
> to update the KConfigSkeleton whenever you fallback to default theme.
> For example:
>     if ( !Render::loadTheme( Settings::theme() ) )
>     {
>         Render::loadDefaultTheme();
>         Settings::setTheme("themes/default.desktop");
>     }
>
> CCMAIL:kde-games-devel at kde.org
>
>
>  M  +36 -31    kgamethemeselector.cpp 
>
>