[Kde-games-devel] Requirement of QCA2 for kdegames?

[Kleag]

Before commiting, do you think these lines in the main kdegames CMakeLists.txt 
would do the job ?

macro_optional_find_package(QCA2)
macro_log_feature(QCA2_FOUND "QCA2" "Qt Cryptographic Architecture" 
"http://delta.affinix.com/qca" FALSE "2.0.0" "Needed to build Ksirk Jabber 
support's GroupWise and Jabberprotocols.")

if (QCA2_FOUND)
  macro_optional_add_subdirectory(ksirk)
endif (QCA2_FOUND)

Gaël
Le Tuesday 11 November 2008 21:34:03 Andreas Pakulat, vous avez écrit :
> On 11.11.08 21:13:32, Albert Astals Cid wrote:
> > A Dimarts 11 Novembre 2008, Andreas Pakulat va escriure:
> > > Hi,
> > >
> > > just found out the hard way that kdegames got a requirement on QCA2. I
> > > find that a bit intrusive. Could the check just be moved into the
> > > top-level CMakeLists.txt and if its not found disable ksirk?
> >
> > I vote for only disabling the parts of ksirk that need QCA2 not all ksirk
> > if that's possible.
>
> Looking at this in ksirk/ksirk/CMakeLists.txt
> FIND_PACKAGE(QCA2 REQUIRED)
>
> I'd say thats not possible. It also means the second such line in
> ksirk/ksirk/iris/src/CMakeLists.txt is meaninglist.
>
> Andreas

-- 
KsirK - a world domination strategy game 
http://techbase.kde.org/Projects/Games/Tactic_and_Strategy/KsirK

KGraphViewer - a GraphViz dot graphs viewer
http://extragear.kde.org/apps/kgraphviewer