[Kde-games-devel] Patch, kbattleship, wish 69383 and grid

[Albert Astals Cid]

A Dilluns 14 Abril 2008, GnuShi va escriure:
> Hi Albert!
>
> Albert Astals Cid schrieb:
> > A Diumenge 13 Abril 2008, GnuShi va escriure:
> >
> > I'm not sure i like this, it may be too obstrusive imho, i'd like to have
> > it configurable. Can you make it an option too?
>
> done
>
> > On the QPainter code you should use doubles and not ints along with the
> > qpainter variants that accept doubles.
>
> I now use the QPointF() things, together with qreal.
>
> > "Grid left" and "Grid right" as action labels suck. "Show Left Grid" and
> > "Show Right Grid" are much better.
>
> done

It's Ok, to me, you can commit if you have an account. If not tell me and i'll 
do.

As a separate patch it would be good if you stored in a KConfig object the 
playsounds/showdialog/showgrid options so they are remembered from one run to 
another.

Albert

>
>
> Thank you for reply
>
> GnuShi