[Kde-games-devel] Patch, kbattleship, wish 69383 and grid

[Albert Astals Cid]

A Diumenge 13 Abril 2008, GnuShi va escriure:
> Hi Folks!
>
> Today, I fixed the following two issues with kbattleship:
>
> 1. Bug 69383 <http://bugs.kde.org/show_bug.cgi?id=69383>: who won the
> game? (usability)
> 2. TODO: optional Grid
>
> 1) To see, who won the game, kbattleship currently shows a small message
> in the statusbar. In case the winner has a highscore, a highscore dialog
> pops up. This patch adds a dialg in case one loses or wins a game
> without having a highscore.

I'm not sure i like this, it may be too obstrusive imho, i'd like to have it 
configurable. Can you make it an option too?

>
> 2) The TODO file mentions an optional grid and Bug 157590 shows, that
> placing torpedos without some kind of hint is not easy. This patch adds
> a grid, wich can be switched on and off, default is on.

On the QPainter code you should use doubles and not ints along with the 
qpainter variants that accept doubles. 	

"Grid left" and "Grid right" as action labels suck. "Show Left Grid" and "Show 
Right Grid" are much better.

Albert

>
>
> As always, please tell me if I missed anything. I'm learning much from
> you comments. ;-)
>
> GnuShi
>
> <http://bugs.kde.org/show_bug.cgi?id=157590>