[Kde-games-devel] Re: KPoker cleanup phase 1 finished

[Andreas Beckermann]

On Tuesday 31 August 2004 22:21, Inge Wallin wrote:
> Hi everybody,

Hi

> I have now gone through all the code of KPoker and made it somewhat more
> readable.  I would like you to test it as much as you can so that we can
> finalize it.
>
> After I am satisfied that I have introduced no new bugs, I will remove the
> old code that is still there and the trace messages and backport this to
> KDE_3_3_BRANCH as there are several bugs in bugzilla that were fixed by
> the new code.

I would propose to wait with the backport to BRANCH until you are sure that 
you didn't introduce new bugs. However that's your decision.

On old code: in my opinion there is no need to keep old code around at all. 
Using cvs diff or cvs up -r we can easily see what you changed anyway.

> But after that there are still a lot of things to do:
>
> * Separate the poker game code from the view code.
>
> * Make the AI possible to use in a game with more than 2 players.
>
> * Port KPoker to use KPlayer and KGame so that we can have network games.

This is the point where I would like you to stop.
It's cool that you fix the bugs and cleaned the code up, but I think it 
doesn't make much sense if we have 2 rewrite branches around (for porting to 
network and AI support you will have to rewrite nearly everything).

My KGame port is basically finished (giving AI support for free - you just 
need to write an AI input), so I don't think we win anything if you redo 
everything, too.

> * Fix the terminology in the program.  A lot of thanks to Ian Wadham for
>   the link to all-poker-rules.com.  I have looked through it shortly and
>   it looks very valuable.
>
> I would especially like some comments from Andreas Beckermann, since the
> code is his to begin with.  I hope he (you) don't think that I have
> ruined your program and spoiled the fun for you.  That was not my meaning.

Hehe :)
I don't care too much about the CVS version anymore. The code in CVS is just 
plain _bad_. Or at least was, before you changed things. I will need to take 
a closer look at your changed when I get a chance to work on my own version 
again, but that's not a big problem.

However as said above - I would really dislike to see a rewrite by you, as my 
own rewrite is already mostly done concerning game logic (it's the UI that is 
in an experimental state).

>  -Inge

CU
Andi