[Kde-games-devel] Patch for konquest

[Inge Wallin]

On Sat, 6 Nov 2004 virgil at vigilite.com wrote:

> Hi all!
> I've created a patch for konquest-http://bugs.kde.org/show_bug.cgi?id=85506.
> I'm not sure about general layout, etc... I can't figure out how to setup the
> layout (the .ui file) to make so it would expand properly on startup. The
> main thing this patch does is add option for different playing styles, I
> tried to implement them-but I'm not sure how well I did that. Also, I took
> the one big calculation out of a "case" and put it in a function. I'd like to
> do a lot of cosmetics if I do more with konquest. I'd like to fulfill some
> other wishlist items (now that I'm slightly familar with the code).
> If you don't like the code, tell me what's wrong with it, not just that it's
> not good. It was kind of an educational patch, so, if you don't like it, tell
> me what's wrong.

Hi Virgil.  I have looked at your patch, and it looks OK to me.  However,
I am not the maintainer, and I will let him decide.

It would be interesting to hear if you have played a lot against it and
what your impression of the new playing styles are.

	-Inge


Inge Wallin               | Thus spake the master programmer:               |
                          |      "After three days without programming,     |
inge at lysator.liu.se       |       life becomes meaningless."                |
                          | Geoffrey James: The Tao of Programming.         |