[Kde-games-devel] Re: Question

[Andreas Beckermann]

On Wednesday 10 September 2003 21:12, Albert Astals Cid wrote:
> I've seen in CVS head of some games of kdegames things like:
>
> #if QT_VERSION < 300
> 	bottomGroup->setFontPropagation( QWidget::NoChildren );
> 	bottomGroup->setPalettePropagation( QWidget::NoChildren );
> #endif
>
> Can they be removed since KDE head should compile at least with QT 3.1 (i
> think it changed to 3.2 days ago) ?

This looks like old code to me. Probably from times when coders tried to 
support both, KDE 2.x and 3.x.
From grep I see that these games are kmahjongg, kshisen and a file in 
libkdegames.

KMahjongg is unmaintained anyway
libkdegames/kgameprocess.cpp was copied from kdelibs/kdeui and that's why 
there is a QT_VERSION < 300 in there. It is just history.

I don't know about kshisen, but I am very sure that 2 #ifs are not enough to 
support KDE 2.x. So it is only history as well.

Conclusion: if you want to spend your work on cosmetics, you can remove them. 

CU
Andi