[Kde-games-devel] Patch for bug #51124 (kmahjongg)

[Médéric BOQUIEN]

Hello,

Here is a patch to correct kmahjongg's bug #51124 ( 
http://bugs.kde.org/show_bug.cgi?id=51124 ). Now when the user clicks on a 
tile, the help animation stops. That way selected tiles are normally 
hilighted.
I've a little doubt on one thing though. To stop the timer, i do :
if( timer->isActive() )
    timer->stop();
If the timer stops after the test and before timer->stop(), it may lead to a 
crash i think. However i've never experienced it as the probability of a such 
case is very low. Do you know if there is a way to avoid that? I fear my 
patch is not thread safe. Is there a kind of HOWTO around about this kind of 
problem? Or is it a problem in fact?
By the way, i thank Dave and Josef for the tip to make nice diff from CVS.
I've noticed the source code is quite messy (lines not aligned correctly) is 
it ok to produce a patch only to make it look better?

Thank you in advance for your help and for considering the patch,

Médéric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 51124.diff
Type: text/x-diff
Size: 2494 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20030523/565e407f/51124.bin