[Kde-games-devel] Patch for Kolf (WHAT SHOULD I DO NOW?)

[Albert 'TSDgeos' Astals Cid]

Hello, you told me to send the patch to jason at katzbrown.com and i did.

I send him the mail on 29 April 2003 and still haven't had an answer from him.

I think http://bugs.kde.org/show_bug.cgi?id=49173 is fairly serious to try to 
patch it.

You can try both, the bug and my solution in first hole of imposible courses 
sending the ball outside the bounds of the hole, in the CVS code you'll see 
your oponent is the one that gets a stroke added to his count when you send 
the ball outside the bounds and you'll see my patch corrects this bad 
behaviour, the player that sends the ball outside the bounds gets 2 strokes 
(1 for the stroke he did and 1 penalizating him from going outside the 
bounds).

The patch is

Index: game.cpp
===================================================================
RCS file: /home/kde/kdegames/kolf/game.cpp,v
retrieving revision 1.163
diff -u -r1.163 game.cpp
--- game.cpp    11 Feb 2003 21:51:04 -0000      1.163
+++ game.cpp    25 Apr 2003 20:48:26 -0000
@@ -2790,15 +2790,13 @@
                        // don't do it if he's past maxStrokes
                        if ((*it).score(curHole) < holeInfo.maxStrokes() - 1

|| !holeInfo.hasMaxStrokes())

                        {
-                               shotDone();
                                loadStateList();

                                // increment curPlayer; he did take a shot,
after all
                                (*curPlayer).addStrokeToHole(curHole);
                                emit scoreChanged((*curPlayer).id(), curHole,
(*curPlayer).score(curHole));
                        }
-                       else
-                               shotDone();
+                       shotDone();

                        return;
                }